Re:We found and fixed a rare race condition in our session h...
by bob1029 on Thursday March 18, 2021 @05:06PM
(#26507555)
It would indeed be a massive amount of data, but bear in mind that only a small fraction of HTTP requests hitting GitHub are actually both authenticated and attempting to change the state of the system. Most requests are unauthenticated read-only and cause no state changes in GitHub.
[ Parent
| on HN ]
Re:We found and fixed a rare race condition in our session h...
by vlovich123 on Thursday March 18, 2021 @05:27PM
(#26507743)
It’s a reasonable theory but step one required to trigger this bug is an unauthenticated request. It’s unclear if their logs indicated that or they got lucky trying to repro that someone thought to try with an unauthenticated request first when the back to back session didn’t repro.
Re:We found and fixed a rare race condition in our session h...
by aidos on Thursday March 18, 2021 @06:28PM
(#26508199)
Could be that there’s some tell tale in the logs.
We recently fixed a bug with incomplete requests by noticing in nginx logs that the size of the headers + the size of the body was the size of the buffer of a linux socket.
Re:We found and fixed a rare race condition in our session h...
by whimsicalism on Thursday March 18, 2021 @05:42PM
(#26507873)
From the writeup, it sounds like the latter, but we obviously can't be sure.