News for hackers. Stuff that matters.
Re:Write code. Not too much. Mostly functions. by redisman on Monday December 21, 2020 @10:56PM (#25502684)
I think setting hard limits on design is a good thing. Creativity needs limits. If your limits can imply something about your desired design goals then that’s a good synergy. It also forces the engineers to think more about design rather than fall back on their goto pattern that may or may not fit the problem. Especially junior and mid level engineers might not have good heuristics on is their design any good or is it just following whatever cargo cult they were brought up in.

Like one engineer on my team implemented this crazy overkill logger and I asked a few questions why do it like this and the answer was that they had implemented it in another language at another company. After that I told them to not have more abstraction layers than concrete implementations when adding a new feature.

Re:Write code. Not too much. Mostly functions. by atoav on Tuesday December 22, 2020 @02:41AM (#25503936)
I think a good programmer should have an "intuition" whether it is worth to build an abstraction for something or not. If in doubt don't do it.

If in hindsight your intuition fooled you constantly, adjust it.

Re:Write code. Not too much. Mostly functions. by redisman on Tuesday December 22, 2020 @03:00AM (#25504048)
I agree but it's kind of too vague to have as a company/team-wide policy
Re:Write code. Not too much. Mostly functions. by atoav on Tuesday December 22, 2020 @08:11AM (#25505872)
Sure, but I wouldn't implement something like that as a policy, but as a guideline. So when someone really goes overboard into one or the other directionyou can point them to the guideline, but there is still some freedom in deciding on the spot.
Re:Write code. Not too much. Mostly functions. by herodoturtle on Tuesday December 22, 2020 @08:56AM (#25506275)
If the need / opportunity to abstract something is highly subjective then it is best left to the team lead / senior architect. For all other obvious cases having a policy as outlined above strikes a healthy balance between autonomy and uniformity.