Fish is plenty popular regardless of all that. Sure, it won't replace Bash, in a sense that you'd have Fish handle all the scripts on the system - that's impossible for backwards compatibility reasons. But it's used as a primary interactive shell, and for custom system & user scripts, by a lot of people.