Re:Hacking up a fix for the broken AppleTalk kernel module i...
by dougg3 on Saturday August 01, 2020 @10:30PM
(#24025836)
That's exactly what I was mulling over in my head today (I'm the author of this blog post). If there's some way to simply provide a v3 of this patch while leaving the credit with the original author, I'd love to do it. I just didn't want to step on anybody's toes, and I don't know the etiquette. I think this kind of thing happens more often than we realize. I've seen similar situations before on other drivers.
[ Parent
| on HN ]
Re:Hacking up a fix for the broken AppleTalk kernel module i...
by l1k on Sunday August 02, 2020 @01:46AM
(#24026641)
Download the raw patch from lore.kernel.org, apply it with "git am", fix up the commit message with "git commit --amend", add your "Signed-off-by" below the existing one, submit with "git-send-email" or "git format-patch" + "msmtp".
That way the commit author remains the same because "git format-patch" includes a "From:" line in the message body which "git am" will interpret as the commit author when the maintainer applies the patch.
Your Signed-off-by is necessary to keep the DCO chain intact: https://www.kernel.org/doc/html/latest/process/submitting-pa...
However, that is now done: https://lore.kernel.org/netdev/086b426f44bc24360cc89476fe18d...
Thank you for the report.
Re:Hacking up a fix for the broken AppleTalk kernel module i...
by dougg3 on Sunday August 02, 2020 @01:17PM
(#24029964)
Thank you! That is very useful to know for the future.
Re:Hacking up a fix for the broken AppleTalk kernel module i...
by paulie_a on Sunday August 02, 2020 @05:50AM
(#24027603)
Honestly, fuck the ettiquite. Reubsmit the patch with fixedup styling and attribution to the original author. If it ruffles some feathers ? Who cares. Hopefully it shakes things up.