News for hackers. Stuff that matters.

A comment on Give some love to your PR.

Re:Give some love to your PR by chdsbd on Tuesday July 14, 2020 @02:55PM (#23836129)
With regards to commits, I think it’s better to _not_ worry about making them nice. I think time is better spent making the PR description clear.

Make as many commits as you want, just “Squash and merge” at the end using your pull request body for the commit message.

[ Parent | on HN ]
Re:Give some love to your PR by paledot on Thursday July 16, 2020 @10:34PM (#23866377)
Please no. Squash and merge means that when someone (maybe you) comes across a strange-looking line of code in 18 months and uses git blame to figure out why it was added, they'll be presented with a 1500-line wall of text with no context.

Commits are a tool. Learn to use them.

[ Parent | on HN ]