The problem you're missing is cost of production: A hydrogen car fundamentally should cost no more than gasoline powered car, and will have a similar range. With batteries, you'll always be limited in range to some extend, and cost reductions have failed to reduce them to anything like a Toyota Corolla type of car.

Batteries don't have a rare earth metal problem, they have a normal metal problem. You need a lot of raw materials to make them, and it's plausible that this will never scale to point where everything can run on batteries.