I had mine replaced twice, but the third revision (which according to Apple is an improved version) has been reliable (except for the key labels wearing off) though I still greatly prefer the 2012 design.
My biggest issue now is the trackpad and its incredibly broken palm rejection that causes the cursor to jump all over the screen. This isn't a settings issue (settings do not help at all) and it was never a problem on older Apple laptops or on the iPad, which has a huge touchscreen with flawless palm rejection. Unfortunately (for me and for Apple), wearing an Apple watch seems to make the broken palm rejection and random cursor jumping even worse.
The keyboards had a higher fault rate and many other issues and Apple has corrected its mistake, albeit 1-2 years too late from a consumer perspective. That's all there is to the story and the only semi-relevant competition to MBPs was STILL just ThinkPads and XPS, even with the main input device being significantly worse than previous iterations.
If you used the 2016 keyboard, you wont say that.
Regarding the 2017 keyboards, I'm not even talking about the fault rate. They had no escape key and the key travel was too small so it was like typing on a touch screen.
No, no it's not really.
It's all about preference and tolerance. I bought my Mum an 'old' Apple USB keyboard (i.e. similar to the pre-2017 laptop keys) when her PC's existing KB broke, as I liked mine very much. Being a life-long touch-typer, she just couldn't get on with it, because the travel was too little for her. She's now very happy with a KB with mechanical (Cherry) key switches.
In contrast, I prefer the older Apple KBs, but can get on perfectly well on my 2017 MacBook Pro's KB; and it's not like a touch-screen at all.
Then maybe I only used broken ones with no perceptible key travel whatsoever.
I agree that when it does work, there is _some_ feedback from keypresses, but seriously, if they can fake the clickability of the touchpad via haptics, why couldn't they do the same for the keyboard? Out of all devices that I develop on, the macbook is the most frustrating, mostly because of the keyboard.
Still, I don't think these issues made the KBs true garbage. Such examples would be nearly any non-MacBook touch pad or often enough display hinges. Far worse than a slightly less convenient keyboard which can always be supplemented with an external bluetooth keyboard as well. Can't really do that with hinges.