Banning apps like iSmokeit would be like imposing your morality on the rest of the world, even if there are well-behaved smokers out there that only smoke in their own private space.
On the other hand apps that help you quit smoking are OK, since smoking IS bad for you in the long-run and dependency on smoking IS a treatable vice.
I understand why people were upset by the Gay-cure app, as people would be angry about an anti-vaccine app, or a pro-Nazi app.
I am not in favor of Apple's app store policy precisely because it encourages nanny-state morality on the flimsiest of moral grounds: profitability.
It reminds me of John Maynard Keynes' attributed quote: "Capitalism is the astounding belief that the most wickedest of men will do the most wickedest of things for the greatest good of everyone."
Should Apple ban iSmokeit and other apps that facilitate smoking?