News for hackers. Stuff that matters.

A comment on How Much Should You Pay Your Engineers to Ensure They Stick Around?. Parent comment

Re:How Much Should You Pay Your Engineers to Ensure They Sti... by sys_64738 on Thursday June 18, 2020 @12:19PM (#23564589)
Why didn't code review catch this? If the review worked the way it's supposed to then you'd be one of the reviewers as you were the original author.
[ Parent | on HN ]
Re:How Much Should You Pay Your Engineers to Ensure They Sti... by mywittyname on Thursday June 18, 2020 @12:40PM (#23564866)
Our setup was you needed one person to approve a merge request. These guys were buddies and would fast-track approvals. Also at that point, there were ~10 contributors to the code base, so things moved quickly.

Other product within the company had a more formal code ownership structure, but this project was only two years old. So there were no owners, other than for infrastructure.

[ Parent | on HN ]