Re:A photo is crashing some Android phones
by wheelie_boy on Wednesday June 03, 2020 @12:27PM
(#23405269)
This could explain why it might not have shown up in testing.
It's not just that the image had a non-sRGB colorspace, it's also that the pixel values in this specific image were out of the expected range.
Re:A photo is crashing some Android phones
by jfkebwjsbx on Wednesday June 03, 2020 @12:54PM
(#23405628)
"Out of expected range" values should be the very first thing to test for...
Re:A photo is crashing some Android phones
by OJFord on Wednesday June 03, 2020 @02:24PM
(#23406838)
And maybe it was; maybe the colour space aspect also was.
Testing combinations of edges is not so common/obvious.
Re:A photo is crashing some Android phones
by arprocter on Wednesday June 03, 2020 @12:54PM
(#23405623)
Could you apply the bugged profile to any image and cause the crash?
GIMP sees it as a JFIF (apparently a predecessor to EXIF) with
"Google/Skia/E3CADAB7BD3DE5E3436874D2A9DEE126 Copyright: Google Inc. 2016"
Quick edit to add that, despite this, I do not believe those changes have made their way into most devices. It seems the error stemmed from the possibility of returning a value over 255 when a histogram was calculated from the addition of color values. As stated in the article, this seemed to result from the use of the Skia color profile in particular. I do not know about other color profiles. The code mentioned by gruez was what I got when the emulator was crashing.