News for hackers. Stuff that matters.
Re:Xfce switches to GitLab by _ix on Sunday May 31, 2020 @11:29AM (#23370152)
In my experience, GitLab's MR UI really lacks performance when the diffs pass a certain length. Similarly sized diffs in GitHub don't seem to have this problem, though.

I think of it as additional incentive to maintain smaller patches for ease of review, but sometimes changes are necessarily large due to complexity. It can be obnoxious to be hamstrung like this.

Re:Xfce switches to GitLab by mangamadaiyan on Sunday May 31, 2020 @08:21PM (#23374371)
Honest question: isn't it far better to review the patch locally on your laptop? I always do this, primarily because I like to be able to go through the callers of functions that the patch modifies, look at the callers of functions that have been introduced, etc.

My decades-long complaint with every single code review system I've been forced to use at my workplaces (which no system I've seen fixes so far) is that they don't let you browse code and examine the diff in its native setting, so to speak.

Re:Xfce switches to GitLab by pluc on Sunday May 31, 2020 @01:14PM (#23370898)
GitHub hides large diffs by default though so maybe that's why
Re:Xfce switches to GitLab by berkut on Sunday May 31, 2020 @05:08PM (#23372744)
So does Gitlab in my experience.