Nixon signed a bill in 1972 that declared just such a "war on cancer". This war has not been won. A few cancers have been reduced, but cancer as a whole remains intractable. Most of the decline in cancer deaths over the past decades are due to fewer people smoking.

I'm not saying that wars on "terror" are a good thing. It's just that cancer is a very tough problem.