Re:I found and fixed a bug in PHP's standard library
by tommica on Monday March 02, 2020 @02:09AM
(#22462334)
>> It happens when you deduplicate code which isn’t an exact duplicate, but only appears to be.
Embarrassing to admit, but until now I didn't think in this perspective - and on hindsight it should be obvious, sometimes code might look duplicate, but is not
Re:I found and fixed a bug in PHP's standard library
by ficklepickle on Monday March 02, 2020 @04:08AM
(#22462845)
Or it starts as duplicate but diverges over time. I've been bitten by the premature deduplication.
Re:I found and fixed a bug in PHP's standard library
by jacobush on Monday March 02, 2020 @06:48AM
(#22463602)
Or worse, the natural progression should be that they diverge, but because they now share some kind of "reused" code in a library or class, an abomination is added to one or both users, just to keep the original "shared" feature.
Great fun.
For instance, one piece of code is supposed to do the same thing as another, but in context it caused a side effect that some other part of the code was inadvertently relying on.