How to write the perfect pull request (2015)

Re:How to write the perfect pull request (2015) by chenhan on Tuesday February 18, 2020 @10:01PM (#22362713)

Your pull request shows exactly what I am talking about. For every force-push it has direct links to the old commit, the new commit and the diff.

Pick the first force push in your PR. It says

> matheusmoreira force-pushed the matheusmoreira:binary-decoding branch from aec04b3 to 87a0b3c on 5 Nov 2019

Click on 'force-pushed'. That's the diff of force-push.

Click on 'aec04b3'. That's the commit before force-push.

Click on '87a0b3c'. That's the new commit in the force-push.

[ Parent | on HN ]

Re:How to write the perfect pull request (2015) by matheusmoreira on Tuesday February 18, 2020 @10:20PM (#22362789)

You're right. I never realized those messages contained links. They do lead me to the old commits.

I don't understand why the code review can't find the commit though.

[ Parent | on HN ]

Re:How to write the perfect pull request (2015) by u801e on Wednesday February 19, 2020 @08:50AM (#22365375)

> For every force-push it has direct links to the old commit, the new commit and the diff.

It's there a way to see the diff between commits that are/were not at the HEAD of the branch? That is, doing something like:

  git diff aec04b3^.. 87a0b3c^

[ Parent | on HN ]