Re:C# Pattern Matching
by oaiey on Wednesday February 05, 2020 @03:50AM
(#22245091)
I agree with your sentiment. But writing good code is also avoiding playing "who knows more language features" between the coder and the reviewer.
I have seen a function which incorporated all new language features of that language version just because the dev could. A simple for loop would have made the same work. The reviewer failed here totally. Readability, Simplicity and consistency in the code base are a thing when reviewing.
Preventing this is a duty of the code reviewer and the team.
I have seen a function which incorporated all new language features of that language version just because the dev could. A simple for loop would have made the same work. The reviewer failed here totally. Readability, Simplicity and consistency in the code base are a thing when reviewing.
Preventing this is a duty of the code reviewer and the team.