Re:Goodbye, Clean Code
by de_watcher on Monday January 13, 2020 @07:14AM
(#22033744)
You can discuss when the rewrite is done, that way it wastes less of your time: you can talk about non-hypothetical existing thing. If the discussion shows that the rewrite is bad then it's his problem: he has to fix or revert.
Plus even the initial rewrite is more time-consuming to do if he doesn't discuss it with the original author beforehand.
Re:Goodbye, Clean Code
by DelightOne on Monday January 13, 2020 @05:50AM
(#22033356)
Should every change be talked over? If not which ones?
If you run scrum, then every ticket should be talked over, and large changes should be discussed. Every change? No. Architectural changes? For sure.
A rewrite of someone else’s code? Most definitely.
Again, there’s a reason why we work in teams, and not as individuals. I trust my teammates too, but rewriting code without any discussion breaks that trust for me.