News for hackers. Stuff that matters.
Re:Goodbye, Clean Code by woutr_be on Sunday January 12, 2020 @05:27PM (#22030020)
I think you’re missing the point as to why I might lose confidence. I’m fine with people being better than me, especially when they explain why they did certain things. But we work as a team, that means that before we do work, we agree on one thing. If suddenly an engineer decides a week later he wants to do something else, then that’s not cool. Even if he has a valid reason for it. Instead you talk to the team, and agree to change.

Again, there’s a reason why we work in teams, and not as individuals. I trust my teammates too, but rewriting code without any discussion breaks that trust for me.

Re:Goodbye, Clean Code by de_watcher on Monday January 13, 2020 @07:14AM (#22033744)
You can discuss when the rewrite is done, that way it wastes less of your time: you can talk about non-hypothetical existing thing. If the discussion shows that the rewrite is bad then it's his problem: he has to fix or revert.

Plus even the initial rewrite is more time-consuming to do if he doesn't discuss it with the original author beforehand.

Re:Goodbye, Clean Code by DelightOne on Monday January 13, 2020 @05:50AM (#22033356)
Should every change be talked over? If not which ones?
Re:Goodbye, Clean Code by woutr_be on Monday January 13, 2020 @07:00AM (#22033668)
If you run scrum, then every ticket should be talked over, and large changes should be discussed. Every change? No. Architectural changes? For sure.

A rewrite of someone else’s code? Most definitely.