I'm Australian but have been to Disneyland (CA) twice and Disney World (FL) once; twice with kids, once without. It's a polished experience for sure, but we spent a lot of time baffled by people in themed t-shirts, spending days there or returning year after year in place of other holiday options.
But within California, we also go to places like the Sierra Nevada mountains and the central coast of CA that we can reach in a day or less by car.
What makes you think they don’t go to those places as well?
Some people wondered why we were only there for the day rather than a full week.
A few weeks after blowing $1k on a day at Disney World, we visited the Amazeum in Bentonville, Arkansas, to the tune of about $40 and my 7yo preferred that. Amazeum and Crystal Bridges as a day out was excellent, for anyone ever in the area.
Dunno, the stuff I was actually enjoying as a kid was the dangerous stuff parents wouldn't approve.
Seems like it's more of a conception of 'what adults think a child would enjoy' rather than what children enjoy.
It’s like watching all your favourite restaurants slowly get replaced by Cinnabon outlets.
Plus, you don't have to spend most of your day waiting in line.
Fundamentally, it's fun escapism. You go spend a few days enjoying some of the same stuff you enjoyed as a kid. My wife enjoys going too, so it's something we can do together. For those of us with kids, it's a fun family activity. Walt Disney was explicit about making a place that was fun for both kids and adults when he conceived of the park. I'd say Disney has succeeded. I enjoyed going before having kids too, though. We don't take every vacation there by any means, but a couple times a year we go and have a blast.
Personally, as an engineer, I really enjoy the work of the imagineers. It's engineering and art combined to bring joy to people, which to me is a pretty pure expression of my own reasons for being an engineer. Incidentally, I started my career doing engineering for effects for live theater, and I also spent time at a company that at one time was a major robotics subcontractor for Disney parks. So there's a component that is admiration for people that do the things I do, but are the best in the world at it.
Beyond that, Disney(land/world) is unquestionably the highest-tier theme park in terms of quality. Everything is just top notch: customer service, theming, ride quality, immersion, cleanliness, etc. So, if the question is why Disneyland instead of Six Flags or even Universal, part of it has to be that Disney is the best in the category they're competing in.