The State Department keeps secrets, and keeps more secrets than it needs to. The NSA's full-time job is generating and keeping secrets. The fact secrets exist (and some secrets should be publicized) doesn't imply unbridled leaking of those secrets is objectively good, and it doesn't imply the world would be a better place if the State Department or NSA operated in the open in general.
On the other end of the spectrum, would you draw the line with Scooter Libby? Would you draw the line with Trump revealing state secrets to Russians behind closed doors?
The double standard between those in power and whistle blowers is out for everyone to see, and there is little that can be done by whistle-blowers to be "careful".
A democracy also can't function with blinding light shining into absolutely every corner. Otherwise, we wouldn't see nearly as many people concerned about privacy in the democracies of the world. In practice, a grey balance appears to be successful.
> What restraint would you advocate in not leaking all secrets?
Some awareness of the possible impact of leaks, and awareness of the contents of leaked documents. Both Snowden and Manning appear to have failed to read all the content they leaked, which is dangerous. In practice, we have gotten fortunate in that there were no obvious immediate lethal consequences to the leaks. But hope is not a strategy.
> On the other end of the spectrum, would you draw the line with Scooter Libby? Would you draw the line with Trump revealing state secrets to Russians behind closed doors?
I'm not sure what lines you're looking for me to draw. So far, all the leaks you've named were dangerous and had significant potential for negative consequences exceeding their benefit. I'm in favor of impeachment of President Trump for the way he has chosen to handle the state secrets he has been entrusted with (along with a host of other, more pressing reasons).
> The double standard between those in power and whistle blowers is out for everyone to see, and there is little that can be done by whistle-blowers to be "careful".
They can always flee to Russia, it seems. ;)
You are suggesting they make judgements, but they are not independent authorities on making such judgements. People who are, are making judgements arbitrarily too, hence why being a legit whistle-blower in any organization is a problem. If you read or listen to Snowden, he worked with journalists to proof the leaks. Yes, he handed them to journalists, because if he went through official channels, nothing would have worked out.
Imagine being a contractor and having no established procedures to go to, and when you blow the whistle, they just bring the hammer on you. Have you read about what Katherine Gun went through for blowing the whistle on a completely illegitimate war where an ally - the US (not her own country) - was pressuring countries in the UN to join the war?
You speak in black and white for Snowden and Manning's morality, but refuse to acknowledge the downright terrible greys of the govts involved.