News for hackers. Stuff that matters.
Re:CVE-2019-1347: When a mouse over a file is enough to cras... by duskwuff on Saturday November 16, 2019 @07:28PM (#21555813)
> The crash is in parsing an executable file.

In a context that doesn't involve executing it. On a Linux system, this functionality would probably be implemented with libelf or libbfd, neither of which depends on the kernel.

Re:CVE-2019-1347: When a mouse over a file is enough to cras... by mike_hock on Saturday November 16, 2019 @07:57PM (#21555889)
Why does it matter if I'm gonna execute it? The parsing doesn't need to be done in kernel space in either case.

Then again, the kernel already has such a gigantic attack surface that it doesn't matter if the ELF parser is part of it.

Re:CVE-2019-1347: When a mouse over a file is enough to cras... by duskwuff on Saturday November 16, 2019 @09:58PM (#21556290)
A UNIX-style process spawning interface, like exec() or posix_spawn(), requires the kernel to have some awareness of the executable format so that it can create a process from an executable image. It doesn't have to support every feature of the format, though.

A model in which this happens in userspace is conceivable, but it'd be pretty weird. Besides, it introduces a chicken-and-egg problem -- if you need a process to launch a process, you need some sort of special case for init.

Re:CVE-2019-1347: When a mouse over a file is enough to cras... by saagarjha on Saturday November 16, 2019 @11:46PM (#21556606)
Your bootstrapping process and init can have their own, hardcoded format.
Re:CVE-2019-1347: When a mouse over a file is enough to cras... by malux85 on Sunday November 17, 2019 @08:37AM (#21557863)
Yeah I though the same thing. init is special
Re:CVE-2019-1347: When a mouse over a file is enough to cras... by jchw on Saturday November 16, 2019 @11:57PM (#21556633)
IIRC, the binfmt elf code in the Linux kernel basically only does enough elf parsing to map everything into memory and kick off the linker. Then the linker does the rest, in userland. It matters because the binfmt code can be very hardened and minimal, whereas the userspace can go and do whatever it wants.

Of course the ELF parsing doesn't literally have to be done by the kernel, but there's no obvious good place to put it otherwise, considering it's a critical bit. If security is the real concern, then why wouldn't you just drop privileges while parsing ELF instead? I don't see the benefit to moving this code outside of the kernel. Maybe somehow moving it to a different protection ring would be helpful; but same for the rest of the binfmts.

I believe the Windows loader that loads PE files, is in fact in the kernel, along with a lot of other stuff. At the end of the day, when the Windows NT kernel was architected, speed was really important and security practices were not matured. I mean, the kernel handles or at once handled a lot of stuff, especially related to the GUI and even network RPCs and network services.

Re:CVE-2019-1347: When a mouse over a file is enough to cras... by mike_hock on Sunday November 17, 2019 @05:36AM (#21557341)
> Maybe somehow moving it to a different protection ring would be helpful; but same for the rest of the binfmts

And goes for a lot of other kernel code.

Re:CVE-2019-1347: When a mouse over a file is enough to cras... by saagarjha on Sunday November 17, 2019 @06:28AM (#21557482)
> IIRC, the binfmt elf code in the Linux kernel basically only does enough elf parsing to map everything into memory and kick off the linker.

Even for statically linked executables?

Re:CVE-2019-1347: When a mouse over a file is enough to cras... by NieDzejkob on Sunday November 17, 2019 @08:04AM (#21557747)
For a statically linked executable, the minimal parsing is enough to kick off the executable directly. After all, the linker is "just" a statically linked executable...
Re:CVE-2019-1347: When a mouse over a file is enough to cras... by rkeene2 on Sunday November 17, 2019 @09:09PM (#21561394)
One could use eBPF to do the parsing safely in the kernel ;-)
Re:CVE-2019-1347: When a mouse over a file is enough to cras... by Varriount on Saturday November 16, 2019 @08:48PM (#21556061)
But here's a question - supposing that this functionality was moved into a hypothetical library "pe.dll"/"pe.exe", how would the kernel load this library or executable? Wouldn't one run into a catch-22 situation?
Re:CVE-2019-1347: When a mouse over a file is enough to cras... by scintill76 on Saturday November 16, 2019 @09:11PM (#21556136)
I think they're saying that userland should handle whatever the mouseover is trying to do (another comment says it displays author and version info embedded in the exe). Things that actually require kernel privileges would remain in the kernel.
Re:CVE-2019-1347: When a mouse over a file is enough to cras... by paulddraper on Saturday November 16, 2019 @10:31PM (#21556397)
The kernel would probably statically link it.
Re:CVE-2019-1347: When a mouse over a file is enough to cras... by saagarjha on Sunday November 17, 2019 @06:29AM (#21557486)
…wouldn’t that have the effect of bringing this code back into the kernel’s address space?
Re:CVE-2019-1347: When a mouse over a file is enough to cras... by paulddraper on Sunday November 17, 2019 @06:52PM (#21560874)
The code itself would be in the kernel, but the "parsing while mousing over" invocation would be on userspace code.

That is, the parse logic could be a library linked by multiple application.

Re:CVE-2019-1347: When a mouse over a file is enough to cras... by Pick-A-Hill2019 on Sunday November 17, 2019 @07:58AM (#21557726)
wouldn't you load/call it during boot or when the mouse driver loads? If you have a mouse, you are almost certainly going to generate an on-mouse-over event at some point. The advantage is that it isn't running in ring 0.