I think they are surely better of with us, and I don't think we increase demand in any way.
I do agree with you that breeding dogs for a life in captivity might not be a morally good thing. Hard to say.
Both my pets are rescues, I have no difficulty with falling in love with rescued animals.
https://www.amazon.com/Run-Spot-Ethics-Keeping-Pets-ebook/dp...
From a review "no matter how well loved they are, our pets are essentially being held captives…. She reminds us that the animals we love and treat as companions ‘are denied nearly all of their natural behaviors, not to mention their freedom"
You want to encourage this outcome even more?
IMO, it’s better that the animal lives a good happy life with their human(s) and doesn’t contribute to pet overpopulation.
And if the human(s) in question need more companion pets, then they can go back to the shelter again and rescue the next one(s).
Dogs evolved alongside humans and were bred to help us with specific tasks like hunting, herding, etc. When you take an animal with a genetic drive to perform certain activities and turn it into a fashion accessory or have it sit alone in a house most of the day, I think the dog tends to go a little crazy. I don't think it's a good life for them. If you can't realistically be with your dog most of the time, or if you don't have a purpose for the dog (like herding sheep) you probably shouldn't have a dog.