News for hackers. Stuff that matters.
Re:Be wary of functions which take several parameters of the... by mlthoughts2018 on Friday September 27, 2019 @08:22AM (#21091069)
In Python I might do something like this.

    class Source(str):
        pass


    class Dest(str):
        pass


    def helper1(a, b):
        assert isinstance(a, Source)
        assert isinstance(b, Dest)
        copyFile(a, b)

    
    if __name__ == “__main__”:
        # obvs use argparse instead and store
        # directly to Source & Dest objects
        # but here to be quick:
        a, b = sys.argv[1:3]
        a, b = Source(a), Dest(b)
        helper1(a, b)
Re:Be wary of functions which take several parameters of the... by collyw on Friday September 27, 2019 @08:28AM (#21091128)
You know how to complicate something very simple.

What is the advantage here? As I would prefer to have the authors original problem than this.

Re:Be wary of functions which take several parameters of the... by mlthoughts2018 on Friday September 27, 2019 @10:04AM (#21092109)
You’re assuming I would endorse this as a good approach in Python in the real world.

I was merely trying to show how to quickly emulate the Haskell example with less code in Python. Both the Haskell approach and asserting on types in Python seem like wastes of time to me personally, and I’d rather just have copyFile by itself and consenting adults can pass the args they want to pass. Use unit tests to make sure you’re not passing paths the wrong way.

Also, what’s with the attitude? “You know how to complicate something very simple” (from ~15 lines of Python?) — geez, you must be a joy to work with.

Re:Be wary of functions which take several parameters of the... by lonelappde on Friday September 27, 2019 @01:52PM (#21094453)
How is writing extra boilerplate tests better than saying what you mean in the primary code?
Re:Be wary of functions which take several parameters of the... by mlthoughts2018 on Friday September 27, 2019 @03:29PM (#21095475)
It addresses exactly the cases you care about, whereas trying to bake it into designs or type system usually adds heavy restrictions that don’t necessarily have anything to do with your exact use cases.

Basically from a You Aren’t Gonna Need It point of view, doing it in tests lets you minimally address the real use case with much less risk of premature or incorrect abstraction.

In my experience, premature abstraction is one of the worst problems in business software. To contrast two far ends of the spectrum, minimalistic patchworks of gross hacking are asymmetrically way better than overhead of premature or incorrect abstractions.

Re:Be wary of functions which take several parameters of the... by throwaway744678 on Friday September 27, 2019 @09:00AM (#21091418)
Python has named arguments; you can use something like:

    copy(source=file1, destination=file2)

and be done with it. Or am I missing something?
Re:Be wary of functions which take several parameters of the... by mlthoughts2018 on Friday September 27, 2019 @10:06AM (#21092132)
This would do nothing to prevent passing it like

    copy(source=file2, dest=file1)
whereas the parent post is trying to use the type system to make this sort of mistake much more difficult to make.
Re:Be wary of functions which take several parameters of the... by Too on Friday September 27, 2019 @10:38AM (#21092477)
Parent would not stop me from doing this either:

    copy(source=Src(file2), dest=Dest(file1))
At some point you will have to make a human decision which file to copy, only thing helping you out in that situation is that it clearly states on call-site which arg is src and which arg is dest, instead of remembering left or right argument.
Re:Be wary of functions which take several parameters of the... by mlthoughts2018 on Friday September 27, 2019 @03:33PM (#21095500)
Sure, I mean ultimately you could shoot cosmic rays at your computer to rearrange bits and bypass any type safety you want. I don’t get why you think this bears relevance?
Re:Be wary of functions which take several parameters of the... by GordonS on Friday September 27, 2019 @06:13PM (#21096724)
I'm not sure how @Too's example is any worse than named parameters - surely the point is that it's just as likely to transpose source/destination either way.
Re:Be wary of functions which take several parameters of the... by mlthoughts2018 on Friday September 27, 2019 @06:34PM (#21096869)
I think the point is that it’s irrelevant, because type checking or type assertions would take place at the parameter ingestion step specifically to render transposing the arguments impossible.

Any solution could be screwed up on purpose if you’re imagining someone at an interpreter prompt getting the arguments wrong or omitting unit tests that verify a certain file is used as source and a different file as dest... which is why this kind of objection just totally doesn’t matter.

Re:Be wary of functions which take several parameters of the... by kedean on Friday September 27, 2019 @02:53PM (#21095116)
But it's the "wrong" solution for python. Python is heavily focused around the idea of duck-typing, and forcing things like this completely blocks duck-typing. What if I want to pass down a complex object that can be used as a string? Python functions should let me pass any string-like thing I want, which is why named arguments are the preferred way to deal with this. You can even force named arguments using kwargs, I believe this is what the boto interface to AWS does.
Re:Be wary of functions which take several parameters of the... by mlthoughts2018 on Friday September 27, 2019 @06:40PM (#21096909)
Your argument doesn’t work. Python affords you tools like metaclasses, __instancecheck__, __subclasshook__, properties and descriptors exactly so you can use the type system to determine how duck typing is handled in whatever cases you want.

Using inheritance and metaprogramming to enforce how and when a given instance or class object satisfies the contract of some interface is a core, fundamental, first-class aspect of Python.

Just because you don’t need to use it very often doesn’t mean “it’s the wrong choice for Python” or anything like that at all.

It is a thing Python goes way out of its way to enthusiastically support, so therefore it is absolutely a Pythonic way to solve problems.

Re:Be wary of functions which take several parameters of the... by Spoom on Friday September 27, 2019 @11:01AM (#21092731)
Such an error would be immediately obvious on code review. The idea is to make it obvious, not foolproof.
Re:Be wary of functions which take several parameters of the... by mlthoughts2018 on Friday September 27, 2019 @06:46PM (#21096960)
In static typing paradigms, the idea most certainly is to make it foolproof and not merely easy to spot. Literally to convert the problem into something the compiler can prove is unbroken.

Not saying this makes static typing better or anything, just pointing out that “easy to spot in code review” is massively different from “absolute mathematical proof this problem isn’t affecting me.”

I’d argue you rarely care about such compiler proofs in real software development, but that’s beside the point if you assume a static typing paradigm has already been chosen.