News for hackers. Stuff that matters.
Re:How to do a code review by flowerlad on Thursday September 05, 2019 @10:18PM (#20892475)
But that sure sounds like they care about proper architecture.

Of course they care about architecture—I don’t think anyone implied otherwise. But at good companies like Google good architecture is a given. Top developers often fall into the pit of over-engineering, and almost never under-architect. So at top companies code reviewers have to be vigilant about over-engineering and rarely have to worry about under-architecting.

Re:How to do a code review by kortilla on Friday September 06, 2019 @02:15AM (#20893484)
>But at good companies like Google good architecture is a given.

Absolutely not. Google’s interview process and inflow of fresh graduates does not bode well for good architecture. Having spent time at G and FB, I can certainly tell you that employees at both are no better at architecting code in a sane way than SWEs at other companies.

Code architecture requires experience. Google does not.

Re:How to do a code review by chrisseaton on Friday September 06, 2019 @05:56AM (#20894346)
I think the hiring bar at places like Google and FB is astronomically higher than almost all other places - they definitely have generally higher skilled people there on average.
Re:How to do a code review by xthrow on Friday September 06, 2019 @08:08AM (#20894890)
Checking for memorized algorithms and an MIT degree do not guarantee good code.

I've seen more horrible code at a FAANG company than in many other places. Complete absence of overflow analysis in C++, race conditions, architecture astronauts, exploding code bases that no one understands any more.

Features are being added on a daily basis, basically what matters is a high line count.

Re:How to do a code review by mav3rick on Friday September 06, 2019 @02:50PM (#20898612)
You clearly haven't seen code at Google and its "base" library.
Re:How to do a code review by mianos on Friday September 06, 2019 @06:58AM (#20894550)
The process does not encourage experience but mainly the ability to remember recent academic programming puzzles. The first comment is correct even though they do have many existing experienced developers that would be in a position to provide architectural advice.
Re:How to do a code review by kortilla on Friday September 06, 2019 @12:33PM (#20897106)
The hiring bar at Google does not test for the ability to organize code coherently. The skill is completely unrelated to algorithms and data structures.

It’s like requiring candidates to deadlift 500 lbs and then assuming it means they can all run marathons.

Re:How to do a code review by mav3rick on Friday September 06, 2019 @03:59AM (#20893869)
Most teams at Google have senior devs that ensure this. The average level is way higher than other companies.
Re:How to do a code review by deepaksurti on Friday September 06, 2019 @12:50AM (#20893159)
So for anyone, including me, when looking out for the next job should be:

- Is `good architecture` a given in this team?

- What are they doing to avoid `over engineering`?

What are the specific questions one can ask to find out the answers to the above two?