Re:How to do a code review
by chrisseaton on Friday September 06, 2019 @05:56AM
(#20894346)
I think the hiring bar at places like Google and FB is astronomically higher than almost all other places - they definitely have generally higher skilled people there on average.
[ Parent
| on HN ]
Checking for memorized algorithms and an MIT degree do not guarantee good code.
I've seen more horrible code at a FAANG company than in many other places. Complete absence of overflow analysis in C++, race conditions, architecture astronauts, exploding code bases that no one understands any more.
Features are being added on a daily basis, basically what matters is a high line count.
You clearly haven't seen code at Google and its "base" library.
The process does not encourage experience but mainly the ability to remember recent academic programming puzzles. The first comment is correct even though they do have many existing experienced developers that would be in a position to provide architectural advice.
The hiring bar at Google does not test for the ability to organize code coherently. The skill is completely unrelated to algorithms and data structures.
It’s like requiring candidates to deadlift 500 lbs and then assuming it means they can all run marathons.