News for hackers. Stuff that matters.
Re:Building Interactive SSH Applications by megous on Monday September 02, 2019 @12:54PM (#20860320)
Then look at the code. You may be surprised.

Looking at the escaping function, it will allow $(execute whatever you want), because it doesn't handle $.

https://github.com/openssh/openssh-portable/blob/master/misc...

Anyway, this depends on being able to specify any username, which while possible, requires you to pass the check that user exists in the system, which will be harder.

But it may still be possible if some weird PAM module is used.

Re:Building Interactive SSH Applications by mbrock on Monday September 02, 2019 @01:36PM (#20860620)
I don't think that function is used other than for logging.

https://github.com/openssh/openssh-portable/blob/b52c0c2e649...

There the "command" variable is the result of the function you mention, but here the use is only for logging. The actual argv for the subprocess is the "av" argument which comes from first splitting and then replacing "%u" etc.

Re:Building Interactive SSH Applications by megous on Monday September 02, 2019 @01:45PM (#20860676)
I see. Good.
Re:Building Interactive SSH Applications by megous on Monday September 02, 2019 @12:58PM (#20860344)
Changing this to use ' instead of " may fix this issue.

https://github.com/openssh/openssh-portable/blob/master/misc...

Because then you'll end up with '$(some)' instead of "$(some)"