Re:Tell HN: Thank you for not redesigning Hacker News
by manigandham on Sunday September 01, 2019 @08:31PM
(#20855883)
It's nothing more than an extra header or query param to denote an AJAX request. Then the server can respond with an empty 200/204 status code instead of the entire HTML page. It's an hour of work and would actually save resources. None of this requires a front-end framework.
[ Parent
| on HN ]
Re:Tell HN: Thank you for not redesigning Hacker News
by iforgotpassword on Monday September 02, 2019 @03:46AM
(#20857434)
No need for custom header or query param, Ajax (xmlhttp) requests already have an extra header field set automatically, so all is needed is some if statement server side, assuming registering the upvote and rendering the page is not entangled in some super crazy way.
Re:Tell HN: Thank you for not redesigning Hacker News
by pmarin on Monday September 02, 2019 @02:56AM
(#20857241)
HN works perfectly with javascript dissabled. Itβs a feature
Re:Tell HN: Thank you for not redesigning Hacker News
by IanCal on Monday September 02, 2019 @03:05AM
(#20857275)
It can still easily work with JavaScript disabled and implement the change.
Re:Tell HN: Thank you for not redesigning Hacker News
by manigandham on Monday September 02, 2019 @05:08AM
(#20857781)
We're talking about it working better when JS is enabled.
Re:Tell HN: Thank you for not redesigning Hacker News
by xur17 on Sunday September 01, 2019 @08:43PM
(#20855931)
You'd need some frontend code to hide the upvote icon though.
Re:Tell HN: Thank you for not redesigning Hacker News
by Deimorz on Sunday September 01, 2019 @09:14PM
(#20856056)
That frontend code already exists and does that every time you vote (line 27 of https://news.ycombinator.com/hn.js). The response content isn't used for anything at all.
Re:Tell HN: Thank you for not redesigning Hacker News
by zeta0134 on Sunday September 01, 2019 @10:32PM
(#20856368)
Nice! I hadn't actually looked at the code before writing my comment. That does seem relatively trivial, so I stand corrected. I didn't realize the clientside code was discarding the response; I sorta naively assumed it was doing a DOM replacement or something equally straightforward.
What a pleasantly tiny script file. More site code should be this easy to read.
Re:Tell HN: Thank you for not redesigning Hacker News
by samtheprogram on Sunday September 01, 2019 @11:59PM
(#20856681)
If you have JavaScript disabled, the response content is used to hide the upvote sign.