Banned C standard library functions in Git source code

Re:Banned C standard library functions in Git source code by LukeShu on Sunday August 25, 2019 @11:02AM (#20793360)

The way I see the list is that it isn't meant to be exhaustive, it's meant to be functions that contributors are likely to try to use. A new contributor might not realize that they should be using Git's internal strbuf.h instead of the libc string functions. It's a way to give them feedback on that from their compiler, before they spend more time on the patch and send it to the mailing list.

[ Parent | on HN ]

Re:Banned C standard library functions in Git source code by masklinn on Monday August 26, 2019 @03:33AM (#20798063)

Also seems mostly for functions which look innocent and are likely to be used but are very easy to misuse.

setjmp/longjmp is not in this category, it might be argued to be easy to misuse but doesn't look innocent and is not likely to be used in normal codebases.

[ Parent | on HN ]

Re:Banned C standard library functions in Git source code by rkagerer on Sunday August 25, 2019 @03:33PM (#20794986)

Might be nice if the error messages suggested such alternatives instead of just saying "banned"?

[ Parent | on HN ]

Re:Banned C standard library functions in Git source code by grogenaut on Sunday August 25, 2019 @05:53PM (#20795841)

I believe the git project welcomes suggestions and discussion via the mailing list, and also accepts patches that like you suggested above.

[ Parent | on HN ]