Re:Banned C standard library functions in Git source code
by jcl on Sunday August 25, 2019 @10:50AM
(#20793298)
Looks like the second vsprintf definition should be "BANNED(vsprintf)", not "BANNED(sprintf)". Not that it matters much, as it only affects the error message.
[ Parent
| on HN ]
Re:Banned C standard library functions in Git source code
by peff on Sunday August 25, 2019 @01:46PM
(#20794333)
Yes, you're right. Patches welcome. We do our development on a mailing list; see https://git-scm.com/docs/SubmittingPatches for details.
However, if you're more comfortable using GitHub PRs, there's a gateway interface at https://gitgitgadget.github.io/.
Re:Banned C standard library functions in Git source code
by ttaylorr on Sunday August 25, 2019 @03:45PM
(#20795047)
I submitted a patch to fix this typo from my fork (which you can see at https://public-inbox.org/git/cab687db8315dd4245e1703402a8c76...).
Re:Banned C standard library functions in Git source code
by gus_massa on Sunday August 25, 2019 @11:02AM
(#20793363)
Nice catch! You can send a "PR", but note that they have their own custom "PR" procedure, not the standard "PR" procedure in GitHub.
> Git Source Code Mirror - This is a publish-only repository and all pull requests are ignored. Please follow https://github.com/git/git/blob/master/Documentation/Submitt... procedure for any of your improvements.
Re:Banned C standard library functions in Git source code
by LukeShu on Sunday August 25, 2019 @11:06AM
(#20793375)
Their "custom" procedure is the `git send-email` command, which has a lot more of a claim to be "standard" than GitHub's custom procedure.
Re:Banned C standard library functions in Git source code
by saagarjha on Sunday August 25, 2019 @11:10AM
(#20793399)
Aside: GitHub’s refusal to provide a feature to close pull requests for mirrors is utterly ridiculous since it requires that people (or bots) go around and disable pull requests and point people to the patch submission process.
Re:Banned C standard library functions in Git source code
by OJFord on Sunday August 25, 2019 @01:08PM
(#20794053)
What's weirdest to me is that it differs from the policy on Issues, which can be turned off in settings.
I sort of get not allowing it, except that it's inconsistent.
Re:Banned C standard library functions in Git source code
by yjftsjthsd-h on Sunday August 25, 2019 @11:11AM
(#20793405)
> not the standard "PR" procedure in GitHub
If it is specific to one implementation, then it is not standard, pretty much by definition.
Re:Banned C standard library functions in Git source code
by notatoad on Sunday August 25, 2019 @01:21PM
(#20794140)
the word "standard" has more than one meaning. it's not standard by the definition of standard that you chose, but you can use your context cues to realize that it's not the definition of standard that OP meant.