My wife and I went on cruises every year for more than 10 years starting mid-90's. At the time, it was more relaxing (with less to do) and gave the opportunity to disconnect. We liked to dress up for dinner and sit with the same (random) people for the entire time of the cruise. Internet was as outrageous of a cost as a phone call at the time so where I worked doing software engineering, I told them to call me anytime! Perfect, the never did... and as a plus we got to visit many ports of call to see what we would like to go back to for longer (taste of different places to decide if we would mesh for a whole week there). Shopping was fine if you take the time to bargain and know your market prices before you go. Tourist traps are still traps at land or at sea... keep your guard up on vacation either way.

Our last cruise was not the same. Lots of fun stuff to do (which we can't complain about trying a few with super long waits). Wifi everywhere (who needs phone calls) to keep in touch with work ALL the time. Random people every meal time at dinner who never dress up (unless you include polo shirts and shorts as dressed up). Basically, for us it did lose appeal to try it. So, for some this is exactly what they want, but lost its luster and special experience.

Advice - pick a cruse line that matches your preferences (kids, no-kids, party, no-party, luxury, casual, etc) and you probably would have a good time.