My mother (honestly). She doesn't use computers (too difficult, no interest) or smartphones (yet another subscription). But with the iPod Touch she can listen to music, call her kids from the other side of the globe with Facetime and the front facing camera, and send e-mails. The last two generations of the iPod Touch brought her from 'never used a computer', well into the 21st century, where she can manage to do stuff online that matter to her.
I bet that there are a lot of casual users, who just want an affordable device to play games, write e-mails, and listen to music, without spending $$$s extra on an iPhone, which also requires a relatively expensive subscription to provide value over the iPod Touch.
The only time I regret it is when I'm traveling, and I'd find it useful to be able to access the internet. But this is rather uncommon.
Honestly, I would be happy to spend extra money on an iPhone without the phone bits. The camera in the iPhone is much better, and the gps would be useful even without an always-on connection.
If they ever get rid of the large classic iPod it will force me to go to another mp3 device.
I really like the matchbook, clip type shuffles for working out. They are super light, pretty much indestructible and have a built in clip.
I know I'm a very specific case, but for me the shuffle is exactly what I need.
Also I am not sure I follow the logic: because Walmart has a MP3 player section, suddenly iPods are must-have items?