Re:Tips for reviewing code you don’t like
by tomlagier on Monday July 08, 2019 @12:47PM
(#20384275)
If it's an extremely common style in the code (something I think definitely should be done), I'd do:
nit: align variable definitions for better readability
If it's a suggestion or new style that I think we should adopt moving forward, I'd say:
Do you think we should align these variable definitions? I think it improves readability.
Then, ideally I'd leave a non-blocking task for them so they can either do it or not but it's not holding up submission whichever way it goes.
Also, I'd likely raise a ticket against a style guide or project-level autoformatter for that class of suggestion, otherwise it just adds noise to every PR.
nit: align variable definitions for better readability
If it's a suggestion or new style that I think we should adopt moving forward, I'd say:
Do you think we should align these variable definitions? I think it improves readability.
Then, ideally I'd leave a non-blocking task for them so they can either do it or not but it's not holding up submission whichever way it goes.
Also, I'd likely raise a ticket against a style guide or project-level autoformatter for that class of suggestion, otherwise it just adds noise to every PR.