News for hackers. Stuff that matters.
Re:Tips for reviewing code you don’t like by gnozzle on Monday July 08, 2019 @10:10AM (#20382830)
I didn't read any of these as watering down. Which ones do you think dilute the message?
Re:Tips for reviewing code you don’t like by LanceH on Monday July 08, 2019 @10:19AM (#20382910)
Exactly. I seems like most of these are jumping off points for starting a conversation.

I may be wrong but I read the article as a senior reviewing a junior's code, in which case the big win is not just getting better code in now, but getting a better developer. Starting the conversation instead of jumping all over them is important.

Even when reviewing a peer, while more terse we tend to phrase things in questions, "Shouldn't this be in a lib instead?" Frequently it's oversight on their part, but sometimes they have their reasons and I learn something in return.

Re:Tips for reviewing code you don’t like by lmm on Tuesday July 09, 2019 @09:09AM (#20391323)
"How do we do X with this change?" is less clear if what you really mean is "This change makes X impossible". "Thank you for your contribution" is misleading when talking about a contribution that simply doesn't meet minimal quality standards. "Please" suggests that you consider something optional, which is misleading if you are actually expressing a requirement. Snide or hyperbolic remarks convey a message; perhaps not a welcome one, but one whose meaning is presumably intentional.