News for hackers. Stuff that matters.

A comment on Vim/Neovim Arbitrary Code Execution via Modelines.

Re:Vim/Neovim Arbitrary Code Execution via Modelines by bla3 on Tuesday June 04, 2019 @07:55PM (#20100324)
It's mildly interesting that the neovim patch for this [1] is just an import of the upstream vim patch [2], but with the test removed.

1: https://github.com/neovim/neovim/commit/4553fc5e 2: https://github.com/vim/vim/commit/5357552

[ Parent | on HN ]
Re:Vim/Neovim Arbitrary Code Execution via Modelines by ryanar on Tuesday June 04, 2019 @08:07PM (#20100383)
I wonder if it is because neovim's testing is setup differently and they wanted to port the patch immediately rather than spend time which they might not have had at the moment to rewrite the test. I suppose the patch was tested upstream, though you would want the test in neovim to prevent a future regression.
[ Parent | on HN ]
Re:Vim/Neovim Arbitrary Code Execution via Modelines by justinnhli on Tuesday June 04, 2019 @08:34PM (#20100533)
A different PR is still open, that presumably would include the test: https://github.com/neovim/neovim/pull/10052
[ Parent | on HN ]