News for hackers. Stuff that matters.
Re:Docker Hub Hacked – 190k accounts, GitHub tokens revoked,... by bayareanative on Saturday April 27, 2019 @03:33AM (#19764349)
You can't. Not without end-to-end integrity with nonrepudiation. Checksums aren't anywhere near enough. But that's Docker.. security optional and run random, untrusted code from the internet.
Re:Docker Hub Hacked – 190k accounts, GitHub tokens revoked,... by cyphar on Saturday April 27, 2019 @05:12AM (#19764646)
And Docker has a signing system but it's only enabled for the official-library builds! So all user images are completely unsigned despite all of the discussions of how secure the notary project might be.

And even if you hosted your own distribution and notary (like we now do for openSUSE and SUSE), you can't force Docker to check the signatures of all images from that server!

Only docker.io/library/* has enforced image signing and the only other option is to globally enforce image signing which means "docker build" will result in unusable images out-of-the-box.

If you look at something like OBS (the Open Build Service that openSUSE and SUSE use to provide packages as well as host user repos), the signing story is far better (and OBS was written a very long time ago). All packages are signed without exception, and each project gets it's own key that is managed and rotated by OBS. zypper will scream very loudly if you try to install a package that is unsigned or the key for a repo changes without the corresponding rollover setup. And keys are associated with projects so a valid rpm from a different project will also produce a warning and resolution prompt. That's how the Docker Hub should've been designed from the start.

(Disclaimer: I work for SUSE, on containers funnily enough.)

Re:Docker Hub Hacked – 190k accounts, GitHub tokens revoked,... by bauerm97 on Sunday April 28, 2019 @01:55AM (#19769590)
The company I work for, Sylabs, is taking what I think to be a pretty great approach to solving this problem. Essentially we've introduced a container image format where the actual runtime filesystem can be cryptographically signed (you can read about that here: https://www.sylabs.io/2018/03/sif-containing-your-containers...). The Singularity container runtime we develop treats this concept of "end-to-end integrity" as a core philosophy. Our docker hub analogue, the container Library, is working to make cryptographic signing one of the fundamentals of a container workflow. We're also actively working on container image encryption, which I think will bump container integrity up a few notches.
Re:Docker Hub Hacked – 190k accounts, GitHub tokens revoked,... by jhasse on Saturday April 27, 2019 @03:43AM (#19764379)
> Checksums aren't anywhere near enough.

Why not?

Re:Docker Hub Hacked – 190k accounts, GitHub tokens revoked,... by toxik on Saturday April 27, 2019 @04:42AM (#19764561)
A checksum’s typical use is to detect transmission errors. A cryptographically secure signature is what’s needed.
Re:Docker Hub Hacked – 190k accounts, GitHub tokens revoked,... by gtsteve on Saturday April 27, 2019 @06:10AM (#19764802)
It uses SHA-256 right? My understanding is that there isn't yet a workable collision attack on the SHA-2 family.

Regardless, I think it's certainly an excellent hardening step.

Re:Docker Hub Hacked – 190k accounts, GitHub tokens revoked,... by blattimwind on Saturday April 27, 2019 @06:42AM (#19764882)
Infosec in 2019: The server I download code from telling me the hash of said code is "certainly an excellent hardening step".
Re:Docker Hub Hacked – 190k accounts, GitHub tokens revoked,... by gtsteve on Sunday April 28, 2019 @11:59AM (#19771813)
Well I was approaching it from the point of view that you verify the image is correct and then you guarantee you'll always use that image and not some other version given that tags are mutable.
Re:Docker Hub Hacked – 190k accounts, GitHub tokens revoked,... by ithkuil on Saturday April 27, 2019 @01:20PM (#19766550)
Can't the hash be verified by the client too?
Re:Docker Hub Hacked – 190k accounts, GitHub tokens revoked,... by subway on Saturday April 27, 2019 @01:47PM (#19766700)
Sure, but who tells the client what the correct hash is?
Re:Docker Hub Hacked – 190k accounts, GitHub tokens revoked,... by krferriter on Saturday April 27, 2019 @05:06PM (#19767638)
If you're the entity who created the image you can retain the original hash and verify it against the downloaded copies. But that kind of defeats the purpose of being able to download docker images across distributed hosts.

They'd really need to be signatures attached to the images, not just hashes.

Re:Docker Hub Hacked – 190k accounts, GitHub tokens revoked,... by darkarmani on Saturday April 27, 2019 @10:03AM (#19765576)
Why do you need a collision? If you control the build, you control the sha-256 hash. But you can't sign it with a key that you don't have.
Re:Docker Hub Hacked – 190k accounts, GitHub tokens revoked,... by kbirkeland on Saturday April 27, 2019 @02:24PM (#19766890)
A hash only provides integrity. A signature provides integirty and authentication.
Re:Docker Hub Hacked – 190k accounts, GitHub tokens revoked,... by jjeaff on Saturday April 27, 2019 @07:20PM (#19768249)
Integrity is all you need as long as you have verified the original image that you have saved the hash for.
Re:Docker Hub Hacked – 190k accounts, GitHub tokens revoked,... by kbirkeland on Sunday April 28, 2019 @02:12PM (#19772663)
Is your argument that you only need integrity if you verified the authenticity out of band?
Re:Docker Hub Hacked – 190k accounts, GitHub tokens revoked,... by jjeaff on Tuesday April 30, 2019 @02:06AM (#19785508)
No, I'm saying you only need integrity to validate you are getting the same thing each time. If I checked and made sure an image is safe, then I can save that hash and know that as long as the has matches, I'm always getting that same safe image.
Re:Docker Hub Hacked – 190k accounts, GitHub tokens revoked,... by kbirkeland on Sunday May 05, 2019 @11:55AM (#19833403)
This is useless without authentication though. You're opening yourself up to attacks on the first retrieve. Sure, you can make sure you're getting the file they want you to have, but you don't know _who_ is giving you that file.
Re:Docker Hub Hacked – 190k accounts, GitHub tokens revoked,... by jhasse on Saturday April 27, 2019 @05:01AM (#19764619)
If I hard-code the checksum, then the base image can't be tampered with at least.
Re:Docker Hub Hacked – 190k accounts, GitHub tokens revoked,... by Robin_Message on Saturday April 27, 2019 @05:23AM (#19764677)
You can tamper with data protected by checksums: they are not designed to be irreversible, just fast to calculate and good at detecting errors, not deliberate manipulations.

Use proper cryptography and don't roll your own!

Re:Docker Hub Hacked – 190k accounts, GitHub tokens revoked,... by jhasse on Saturday April 27, 2019 @05:31AM (#19764693)
Wouldn't that mean you need to find a collision?
Re:Docker Hub Hacked – 190k accounts, GitHub tokens revoked,... by r3bl on Saturday April 27, 2019 @06:11AM (#19764806)
There's a good chance that someone who can modify your base image can also modify the checksum you're showing to whatever is the new checksum.

For example, when Linux Mint's ISOs were briefly backdoored, the attackers also changed the checksum shown on the website: https://www.zdnet.com/article/hacker-hundreds-were-tricked-i...

Re:Docker Hub Hacked – 190k accounts, GitHub tokens revoked,... by jjeaff on Saturday April 27, 2019 @07:23PM (#19768260)
But that's not the point here. The point is that you choose an image and verify that it is safe and then pin the hash. So I can pull that hash a thousand times over from whatever source I want and I can be sure it is always the same image that 8 originally verified. I don't care who has it or who now has control over the site because if the image doesn't match the hash, then it isn't mine.
Re:Docker Hub Hacked – 190k accounts, GitHub tokens revoked,... by dlitz on Saturday April 27, 2019 @06:14AM (#19764813)
I think yall are using the terminology differently from each other in this thread. "Checksum" historically did not imply resilience against intentional modifications.

Nowadays, it's arguably a best-practice when designing a new protocol or storage format to simply make all checksums cryptographically strong unless there's a reason not to. I think that might be where the confusion is coming from.

Re:Docker Hub Hacked – 190k accounts, GitHub tokens revoked,... by jhasse on Saturday April 27, 2019 @09:35AM (#19765412)
You're right, I confused checksum with hash.
Re:Docker Hub Hacked – 190k accounts, GitHub tokens revoked,... by MattPalmer1086 on Saturday April 27, 2019 @06:04AM (#19764789)
The issue is, how do you verify the checksum you are using is valid. If you obtain the checksum from the same place you get the image, then an attacker can simply calculate a new checksum for the malicious image and publish it too.

I guess if you were really sure you had obtained a checksum prior to the service compromise, then that would give reasonable assurance the image was not tampered with.

Re:Docker Hub Hacked – 190k accounts, GitHub tokens revoked,... by ithkuil on Saturday April 27, 2019 @01:25PM (#19766584)
Checksums/fingerprints can help mitigating the problem of _changing_ images people already use. As you correctly point out they don't solve the problem of authenticated distribution.

Assuming you have fetched a given image and captured its sha in a config file in your version control (e.g. a kubetnetes manifest), then whenever you deploy a container you are sure that you're not affected by exploits happening _after_ you saved the fingerprint.

Re:Docker Hub Hacked – 190k accounts, GitHub tokens revoked,... by richardknop on Monday April 29, 2019 @05:28AM (#19776942)
You create the docker image on your local computer, create checksum and write it down / remember it. Then you just use this checksum when downloading the image from other computers to check it's the same one. This only works for images created and uploaded by you of course, for images created by other people it does not work.
Re:Docker Hub Hacked – 190k accounts, GitHub tokens revoked,... by joveian on Saturday April 27, 2019 @02:41PM (#19766963)
Second preimage mostly, which is harder than collision with most common algorithms (even MD5 might still be secure for this, not that anyone should use it for anything at this point). Collision resistance is only important if someone can create two versions at the same time that have the same hash and wants to quietly switch them later.

Using SHA-256 as you describe works well and is widely used by package systems to ensure that source code being built does not change. Signatures can be better for determining if the initial image is valid if the signing is done away from the distribution infrastructure since development machines might be more secure than distribution infrastructure (and if not you will have problems either way). You still need to get the correct public key to start with. However, if you do have a good image by luck or actually secure enough distribution infrastructure then SHA-256 will certainly let you know that you get the same one later. Signatures almost always sign a cryptographic hash of the message and not the message itself.

Re:Docker Hub Hacked – 190k accounts, GitHub tokens revoked,... by orisho on Saturday April 27, 2019 @06:08AM (#19764796)
I think his point is that for some checksums it could be trivial (and for some, tools already exist). Checksums aren't designed for this, while on the other hand secure hashing is. As a result, authors of hashing algorithms often attempt to mathematically prove their strength and resistance to a collision.
Re:Docker Hub Hacked – 190k accounts, GitHub tokens revoked,... by jhasse on Saturday April 27, 2019 @06:11AM (#19764807)
Docker uses SHA256 though, for which it isn't trivial.
Re:Docker Hub Hacked – 190k accounts, GitHub tokens revoked,... by orisho on Saturday April 27, 2019 @03:49PM (#19767296)
Yes. The previous comments were about checksums, which SHA256 is not.
Re:Docker Hub Hacked – 190k accounts, GitHub tokens revoked,... by JohnHaugeland on Saturday April 27, 2019 @10:52AM (#19765815)
that's most modern programming languages too