Effective Code Reviews – A Primer

Re:Effective Code Reviews – A Primer by ponyous on Thursday March 07, 2019 @11:29AM (#19329365)

Well depends, having 0 testing sucks too. I would argue 100% TDD can be a code smell, especially if you try to unit test everything. Use testing where it makes sense. Got some complex business logic in some function with several different edge cases? Cover them in test cases, it will also serve as documentation.

If you have a problem with #3 you might as well have the problem with #5. You don't want to automate everything, only where it makes sense.

[ Parent | on HN ]

Re:Effective Code Reviews – A Primer by misterman0 on Thursday March 07, 2019 @11:47AM (#19329551)

>> Use testing where it makes sense.

I agree!

>> Got some complex business logic

So complex the only one who understands it is...who? A test?

[ Parent | on HN ]

Re:Effective Code Reviews – A Primer by volkk on Thursday March 07, 2019 @01:33PM (#19330691)

i'm not sure what you're arguing here. if you have a complicated codebase you write tests so that when you add other code, you have a bit more confidence that you're not breaking things. furthermore, if a new person joins a team, they can use old tests to understand what the hell is happening in the code otherwise you just have an unadulterated mess of code to read through.

you're dealing with humans on a day to day basis that err very easily. the dumb mistakes i've made because there was a lack of tests are countless.

[ Parent | on HN ]