News for hackers. Stuff that matters.
Re:Ask HN: How to peer review when we're both new to the code? by Isammoc on Thursday February 07, 2019 @04:04AM (#19103977)
In my team, anyone can review the code made by anyone. That means two seniors can review each other but two juniors too.

What is important exactly in a code review depends on the team. But generally, the same items are reviewed:

* Are team conventions applied?

* Can another understand the new code?

* Is code resolving the issue?

* Can I think about a better code? Something to refactor?

Even two juniors can ask this questions and try to answer them.

There are no comments on this comment yet.