Re:AT&T will put a fake 5G logo on its 4G LTE phones
by ashishb on Saturday December 29, 2018 @11:57PM
(#18787483)
> An untyped (that is, it cops out to int) bunch of public static’s that should’ve been an enum.
Java platform code does not use enums since they are more taxing in terms of memory usage. Till Google I/O 2018, Google use to officially recommend that you should avoid enums in your app code if you can.
An untyped (that is, it cops out to int) bunch of public static’s that should’ve been an enum. Daft combination of builders and constructors. Magic numbers. Adapter methods that should go into their own class. Validators that should also go into their own class (and even there, implemented differently, not as a parameterless method). Transformers that could be modeled as their own class (all these “in their own class” are for testabilty.) some of the names in these adapters suggest some other domain concerns (UI) are leaking into this model class.
IOW, it’s a mess by any standard