Re:Modern Code Review: A Case Study at Google [pdf]
by kikoreis on Friday September 21, 2018 @08:12AM
(#18039093)
Where I have worked I am semi famous for a style of code review which almost exclusively is based on asking questions. A lot of the questions are around design rationale, because the "why" is often not captured. Questions can either lead to code changing, "oh, you're right, that doesn't make sense" or "missed that!" , or a comment being added to ensure the rationale is captured. Developers seem to really appreciate this type of review, in contrast to the style you have outlined.
[ Parent
| on HN ]
Re:Modern Code Review: A Case Study at Google [pdf]
by kangax on Friday September 21, 2018 @09:32AM
(#18039534)
This is such an underrated comment.
I love this style of code reviews and it's the one I've experienced best discussions with. It goes in line with assuming that you, as a reviewer, don't know what the intentions/rationale are rather than blindly dictating your solution. A lot of times the reviewer that says "this is wrong" is then explained to why it was done a certain way and is the one proven wrong. Questioning yourself as a reviewer is always a good idea. Asking questions gives feedback without coming off aggressive/judgemental/patronizing.
Re:Modern Code Review: A Case Study at Google [pdf]
by fatnoah on Friday September 21, 2018 @01:08PM
(#18041100)
This is essentially what I do. While I do note some obvious "bad things" I'm usually trying to understand the code and the thought process behind it. The result is usually a) me learning something b) better documented code and c) the occasional code change resulting from the aforementioned "missed that" or "that makes sense" moments.
Re:Modern Code Review: A Case Study at Google [pdf]
by sclangdon on Friday September 21, 2018 @10:59AM
(#18040171)
I do something similar. I try to start most of my comments with "What would happen if...". I find that people are more responsive if they work through it themselves rather than if I'd said "X is wrong, you should have done Y".