Re:iOS 12 Safari Array reverse bug
by vanderZwan on Wednesday September 19, 2018 @07:32AM
(#18023419)
What is extra frustrating is that this is an answer StackOverflow. The whole point is to give clear, educational explanations. Well, the solution is only 21 lines, so why not explain the code snippet instead?
(function() {
function buggy() {
function detect() {
var a = [0, 1];
a.reverse();
return a[0] === 0;
}
return detect() || detect();
}
if(!buggy()) return;
Array.prototype._reverse = Array.prototype.reverse;
Array.prototype.reverse = function reverse() {
if (Array.isArray(this)) this.length = this.length;
return Array.prototype._reverse.call(this);
}
var nonenum = {enumerable: false};
Object.defineProperties(Array.prototype, {
_reverse: nonenum,
reverse: nonenum,
});
})();
Look at how elaborate the repo is by comparison:It has a nice logo though I can't find a link to the merch store or author's Patreon.
Re:iOS 12 Safari Array reverse bug
by KyleDavidE on Wednesday September 19, 2018 @09:52AM
(#18024151)
? The snippet you showed is literally the exact code of the module: https://github.com/fanmingfei/array-reverse-ios12/blob/maste...
The rest is just tests / npm config / license
Re:iOS 12 Safari Array reverse bug
by vanderZwan on Wednesday September 19, 2018 @10:02AM
(#18024210)
When I posted this, the snippet was not part of the answer being discussed. There was only a link to a node module.
Re:iOS 12 Safari Array reverse bug
by raverbashing on Wednesday September 19, 2018 @08:22AM
(#18023638)
> answer StackOverflow ... the solution is only 21 lines, so why not explain the code snippet instead?
You answered your own question. Especially in the JS world
Re:iOS 12 Safari Array reverse bug
by jbreckmckye on Wednesday September 19, 2018 @11:35AM
(#18024950)
I was so offended I raised an issue just to throw a strop: https://github.com/fanmingfei/array-reverse-ios12/issues/16
Re:iOS 12 Safari Array reverse bug
by realPubkey on Wednesday September 19, 2018 @05:21AM
(#18022941)
Also if now everyone starts to polyfill this garbage, then apple will not patch it before the next release of iOS.
everyday we stray further from god