News for hackers. Stuff that matters.

A comment on Linus Torvalds apologizes for his behavior, takes time off. Parent comment

Re:Linus Torvalds apologizes for his behavior, takes time off by acjohnson55 on Sunday September 16, 2018 @11:20PM (#18002921)
I would avoid saying anything like "this code is awful". Just say "I can't approve this because X, Y, and Z".
[ Parent | on HN ]
Re:Linus Torvalds apologizes for his behavior, takes time off by circlefavshape on Monday September 17, 2018 @06:06AM (#18004531)
YES! Saying "this code is awful" in a code review is absolutely the wrong approach. What's your expected outcome? For the person who wrote it to say "oh yeah, silly me, I'll rewrite it so it's good"? They probably thought it was good, that's why they submitted it.

Don't make value judgements, point out what's wrong and how it causes problems

[ Parent | on HN ]