News for hackers. Stuff that matters.
Re:Companies worry more about access to software developers ... by ryandrake on Monday September 10, 2018 @01:37PM (#17953496)
Sorry, not sure if I read correctly, but are you advocating against code reviews before committing code?
Re:Companies worry more about access to software developers ... by JoeAltmaier on Monday September 10, 2018 @05:44PM (#17955483)
I'm advocating against self-appointed police setting themselves up as arbiters of style and technique, who delay projects by weeks and multiply the effort required to pass their arbitrary notions of how a pointer should be compared to null or whatever. Its insulting, pointless and aggravating, especially when you spend Labor Day weekend cranking to get a feature ready for a demo, but can't check it in Monday because so-and-so doesn't like some style issue.
Re:Companies worry more about access to software developers ... by ryandrake on Monday September 10, 2018 @07:45PM (#17956079)
Sounds like valid criticism of a particular review process or reviewer, not reviews as a general gate to pushing code. I’ve worked at places without mandatory code review and the code in those places is consistently awful.
Re:Companies worry more about access to software developers ... by JoeAltmaier on Tuesday September 11, 2018 @09:43AM (#17959606)
I've never experienced anything else along those lines, so your mileage may vary of course. But once a company falls into this trap, its not something the new guy can fix.