News for hackers. Stuff that matters.

A comment on My bag of tricks – loose notes, design patterns, rules-of-thumb. Parent comment

Re:My bag of tricks – loose notes, design patterns, rules-of... by AllegedAlec on Friday August 31, 2018 @10:02AM (#17885636)
> Well that they fail and that they take minutes to run isn't a bad thing; what is bad is that broken things end up on master.

You don't understand; they are continually broken on master.

Furthermore, you assume that we only commit to master after reviews etc have been done. This isn't the case. Commits, even intermittent commits, are pushed to master, and reviewed from there.

[ Parent | on HN ]
Re:My bag of tricks – loose notes, design patterns, rules-of... by pc86 on Friday August 31, 2018 @10:07AM (#17885676)
> Commits, even intermittent commits, are pushed to master, and reviewed from there.

I think most people would agree that's an objectively wrong way to do it.

[ Parent | on HN ]
Re:My bag of tricks – loose notes, design patterns, rules-of... by AllegedAlec on Friday August 31, 2018 @10:25AM (#17885820)
Agreed. I've been saying for a long time we should do it differently, but so far I've had no success.
[ Parent | on HN ]
Re:My bag of tricks – loose notes, design patterns, rules-of... by sopooneo on Friday August 31, 2018 @12:31PM (#17886887)
You have to make the people love you. Then they will follow your good advice joyfully. In fact they'll follow your bad advice just as much, so be careful you don't get promoted to VP.
[ Parent | on HN ]