News for hackers. Stuff that matters.
Re:Another flaw in Signal desktop app leaks chats in plaintext by charleslmunger on Friday May 18, 2018 @08:40PM (#17105996)
> The issue was using innerHTML (or rather $.html()) with strings concatenated together from user input. Something you should never do. Could as well just call eval() directly on it, or pass the input to gcc, compile it and run the resulting binary.

Yes, but most engineers would look at that last element and say "what on earth is going on here", where $.html() being dangerous is something that engineers who don't usually work on web might not know about. You're right about blaming the DOM spec, but there's no actual reason for signal desktop to interact with that poorly designed spec except that they chose electron as a framework.

There are no comments on this comment yet.