Re:Another flaw in Signal desktop app leaks chats in plaintext
by cyphar on Friday May 18, 2018 @04:08AM
(#17099521)
What's incredible is that the author actually had to modify an XSS test so that it read:
> const expected: string = "Hello<br><script>alert('evil');</script>World!";
(Meaning they actually changed a line that had "<script>alert('evil')</script>" and didn't notice.)
I have seen this before though, with some folks removing path sanitisation code I added several years prior to fix a CVE. So it's not uncommon (it also got merged, so when I found out and fixed it I added a very large and scary comment to stop people from doing it again).
Re:Another flaw in Signal desktop app leaks chats in plaintext
by mercer on Saturday May 19, 2018 @10:12AM
(#17107964)
Why is this a 404 now?
Re:Another flaw in Signal desktop app leaks chats in plaintext
by Stephen304 on Saturday May 19, 2018 @10:49AM
(#17108092)
Looks like grrowl copied and repasted the truncated display text of the link. The full link is 2 comments up: https://github.com/signalapp/Signal-Desktop/commit/9d41b8616...
This is an absolutely egregious rookie error. I wouldn't touch the Signal desktop app with a 10 foot pole after seeing that commit.