I think that's a little too specific and doesn't fit a lot of hobbies. People do often make a little money from their hobbies: fixing up and reselling old cars, thrifting and selling on eBay, refinishing furniture, putting up videos on YouTube.
Also, many hobbies have time-critical components. Even all-American pastimes like sports require you to not miss the game.
I'd crystalize it like so: A hobby is something you sink time into where failure has no negative consequences.
Since people like to pick nits here, that probably needs a couple of qualifiers. The sunk time itself can be considered a negative consequence. And the failure may have negative consequences within the hobby — if you accidentally crush your ship in a bottle, you aren't gonna be happy.
But the negative consequences of failure don't bleed out into anything else in your life. You have no need to succeed. That encapsulation of failure is what I think makes hobbies safe and thus encourage fun and a sense of play.
The reason it's so often disastrous to turn your hobby into a job is exactly because of that reason: it means you are now adding real stakes to the game. If you failed frequently and safely when it was a hobby, that was fine and you might still love the hobby. Once those failures matter, it can upend the whole cost/benefit calculation.
Not saying you're wrong, just throwing a wrench into the works because it has been on my mind and I'm curious what the hive mind has to say.
The deadline part is a more onerous constraint but still I like his definition better than yours because of the hobbies that have negative consequences (like the mountaineering).
I think the best definition would be a modification of "A true hobby is something that you don't do for money and that has no deadlines attached." but instead of saying what it isn't (deadlines, money) say what it is:
A true hobby is a personal activity that has sentimental value.
The meaning of 'personal' here is that it would be detrimental for the activity to be attached to the world (through things like deadlines or money) and it has sentimental value i.e. it is not a chore but is actually enjoyable.
Another observation is that you sometimes want to share personal things with others but only if they belong to the group you trust with this particular secret. Hobbies can therefore have attachments but only to the world of that hobby (some niche community probably). This world can then become a gateway to the real world again since if you rise in the ranks of this community you become a part of the leadership that straddles the border between the community and the real world, the members of the community will often pay for this 'protection' - as an example, pro gamers legitimize the hobby of gaming since it becomes a possibility, however unlikely, to make a living playing games. This protection allows hobbyists to fully engage in their activity without concern for reality, hiding behind the delusion of one day becoming pro or in other cases staying relatively anonymous or legitimate due to the more extreme people taking the spotlight. For those who stand the vanguard it is a cutthroat life very much attached to the real world (deadlines, money, training, hard work) the hobby has therefore ceased to be a hobby and has become a job or lifestyle.
I also think specialization works against this idea. In the early 80s a computer game was a job of a single or few developers: they were moving a few pixels, using limited colors, and with very limited sound capabilities. Now it is very difficult to impress ourselves or others working in small groups. There are exceptions like computer security, demo scenes, etc but the participants are outliers and not the common denominator.
Additionally I think maintaining ownership and flexibility of schedule is good to a certain point, but having deadlines and external stakeholders (which you preferably choose and control) also helps for motivation. It's always more rewarding when you meet those than question your commitment to your hobby when you forget about it for a few months because "you were busy".
I class myself as taking "decent snapshots", have a good DSLR and a fair bit of experience. I've shot three weddings for family & friends, all of them were under duress. None of the couples were going to pay for a photographer so I was pretty much the only alternative to them asking people for whatever pictures they happened to take and share.
On the day it was a balance between taking part in the wedding and getting decent pictures, including the formal shots. I was pretty nervous and didn't like the directing part, I prefer to be anonymous in the background. Not everything turned out well but compared to the alternative they were all very happy and I did get good coverage of the days events. I did sort of enjoy it and was well prepared with kit & plans for the day plus it was certainly an experience but have said to myself never again.......
I began charging a small fee for my time a few years ago (I justified that I should make at least half my freelance dev rate) but even that small price totally ruined the experience for me. Once it became a job it wasn't fun. Now I'm back to doing pro-bono events mainly for non profits and it's fun again.
If you don’t finish your costume in time for a con, you miss it. No big deal.
If you miss delivering a costume for client for a con, very big deal.
Becoming a guild master ruined WoW for me. A successfull guild is ran like a business. People get upset if you take a raid night off.
Being a guild leader was fun for a little bit, but it eventually killed my love for the game
A true hobby is something that you don't do for money and that has no deadlines attached.
Once you start accepting payment to do something, someone else is setting expectations for your work. If you are a pretty good hobbyist photographer, one of the worst things you can do is shoot a wedding. Shooting a wedding, even for professional photographers, is one of the highest stress environments possible for photography.
If you have deadlines associated with your hobby, what happens if they "slip"? For example, if you set an artificial deadline to make your first ambitious Arduino project that will do something that will make your friends impressed and you get stuck somewhere, does it really matter?
Nothing needs to be said about the combination of paid work and deadlines. That is not hobbying, that is contracting. A long time ago, I did some subcontracting on iOS development. Beautiful weekend? Didn't matter. Monday deadline for client. Sucked.