News for hackers. Stuff that matters.
Re:New tools for open source maintainers by maxnoe on Wednesday April 18, 2018 @05:13PM (#16871241)
Can someone explain the Pull Request restrictions?

What does: "the changes are not explained in the commit body" actually mean?

Is this opt in?

Re:New tools for open source maintainers by claudiulodro on Wednesday April 18, 2018 @09:41PM (#16872718)
I believe it's an attempt to stop PRs like this: https://github.com/woocommerce/woocommerce/pull/19545

We get at least one of those a day and they are user error, spam or something. Definitely a useful feature for popular open source projects.

Re:New tools for open source maintainers by justinclift on Saturday April 21, 2018 @07:20PM (#16893902)
That one (in your URL) looks like the result of a PR between mismatched branches. eg instead of being the intended/correct source and destination branch, it's between two branches fairly far apart.

Thus a shed load of commits to try and resolve the difference.

Hopefully this new behaviour does fix the problem. On the other hand, I have a feeling it might alienate potential contributors who just aren't that familiar with git yet and could instead do with some guidance (ie how to use the correct branch to base changes on).

I guess we get to find out. :)

Re:New tools for open source maintainers by pietroalbini on Wednesday April 18, 2018 @05:40PM (#16871464)
As far as I understood this means you can't create pull requests of branches you don't have push access to (for example other people's forks) unless you're a project collaborator. It shouldn't affect your own branches.
Re:New tools for open source maintainers by rurban on Wednesday April 18, 2018 @05:31PM (#16871392)
I see this new feature as a bug.

If you don't like a pull request close it or ignore it. But disabling accidental and “drive-through” pull requests sounds very bad to me.

Re:New tools for open source maintainers by chr1 on Wednesday April 18, 2018 @06:05PM (#16871657)
Sometimes people use compare view and accidentally create pull requests without description from branches on which they do not have any commits.

On popular projects this happens often enough to become annoyance for maintainers.

I don't see any case when opening a pull request from someone else's branch and without a description could be done intentionally.

Re:New tools for open source maintainers by TheDong on Wednesday April 18, 2018 @08:36PM (#16872483)
If you wish to create a pull request, you can always push the content you wish to PR to your fork of the repo and create one.

It does add an extra step if you wish to PR someone else's code (you now have to fetch it from their remote, push it to yours, and then make the PR vs directly cross-repo PR between two repos you don't own).

It's not a heavy extra step though and I don't see this as removing the ability for any number of small PRs.

Re:New tools for open source maintainers by handbanana on Wednesday April 18, 2018 @06:15PM (#16871734)
If I understand the changes correctly, I agree.