Re:PullRequest pulls in $8M Series A just months after scori...
by kornish on Friday April 13, 2018 @07:40PM
(#16834886)
Totally. I'm also curious about consistency: if you get reviewers who prefer different idioms and stylistic points between review, what does that do for codebase style over time? I wonder how their quality control operates on the reviewer side.
[ Parent
| on HN ]
Re:PullRequest pulls in $8M Series A just months after scori...
by lyal on Friday April 13, 2018 @08:12PM
(#16835014)
We both internally and have customer rate reviews -- we also establish corpus details with customers during the onboarding process. On the whole, we believe it's valuable to stay within the structure established within a team and nudge things forward rather than making wholesale changes to disrupt.
Re:PullRequest pulls in $8M Series A just months after scori...
by encoderer on Friday April 13, 2018 @07:54PM
(#16834931)
If that’s what you’re covering or expecting from code reviews you’re doing it wrong.
The only right answer here is automated code formatting and linting.
Re:PullRequest pulls in $8M Series A just months after scori...
by aassddffasdf on Friday April 13, 2018 @08:07PM
(#16834987)
That is not what is meant by "idioms and stylistic aspects". Take, e.g. `o.map(v => ...).getOrElse(v2)` vs `o match case Some(v) => ... case None => v2`. The former is idiomatic and preferred over the latter (but of course some jackass somewhere will disagree and argue incessantly about it).
Re:PullRequest pulls in $8M Series A just months after scori...
by kornish on Friday April 13, 2018 @08:11PM
(#16835011)
Exactly right. I'm not referring to which line the braces go on, but rather how domains get modeled, how errors are handled, how functional or imperative the code is, etc.
Re:PullRequest pulls in $8M Series A just months after scori...
by paulddraper on Saturday April 14, 2018 @09:50PM
(#16840644)
Side point, but AFIAK `fold()()` is most idiomatic in Scala.
Re:PullRequest pulls in $8M Series A just months after scori...
by Nullabillity on Sunday April 15, 2018 @04:47PM
(#16844863)
And yet, `match` is the only one that gets correct type inference.
`.map(ifSome).getOrElse(ifNone)` infers the type from `ifSome`, and forces `ifNone` to conform.
`.fold(ifNone)(ifSome)` infers the type from `ifNone`, and forces `ifSome` to conform.
Meanwhile, `match { case Some(x) => ifSome(x); case None(x) => ifNone }` will correctly infer from both cases at once, and give you the greatest common ancestor.
Re:PullRequest pulls in $8M Series A just months after scori...
by paulddraper on Tuesday April 17, 2018 @06:19PM
(#16862806)
Yeah, I agree. ¯\_(ツ)_/¯