News for hackers. Stuff that matters.

A comment on System Shock 1 source code released under GPL. Parent comment

Re:System Shock 1 source code released under GPL by tibbon on Thursday April 05, 2018 @06:58PM (#16769540)
I put in a PR to fix that: https://github.com/NightDiveStudios/shockmac/pull/2

Best thing about GPL code is that we can fix it!

[ Parent | on HN ]
Re:System Shock 1 source code released under GPL by amatecha on Thursday April 05, 2018 @09:26PM (#16770243)
Changing line endings isn't a "fix"... if you do that, it's unusable on the intended system upon which you would work on this code - System 7 or Mac OS 8.
[ Parent | on HN ]
Re:System Shock 1 source code released under GPL by Kristine1975 on Friday April 06, 2018 @04:13AM (#16771751)
I'm pretty sure CodeWarrior was able to deal with any kind of line endings: CR, LF, CR+LF.
[ Parent | on HN ]
Re:System Shock 1 source code released under GPL by tibbon on Friday April 06, 2018 @11:08AM (#16773796)
This might be a dumb question (I spend most of my days in Ruby), why can't this compile with gcc and make? It's all just C (and a few files C++) right?
[ Parent | on HN ]
Re:System Shock 1 source code released under GPL by carussell on Thursday April 05, 2018 @11:53PM (#16770765)
The fix that needs to be made here is in Git, which fails to process line endings in a sane way (and includes a bunch of insane, poorly documented config options that approach the problem completely sideways).
[ Parent | on HN ]