I agree many books in the self-help genre are basically just "motivational porn", but I wouldn't dismiss all of them. I have read some self-help books that gave me genuine insights that I have put into successful practice with real effects.