That's interesting, but also not so surprising. China has had decades of directing primary engineering/manufacturing efforts towards reverse engineering western products, or executing specific designs specified from western clients. The attitude of looking to someone else's engineering to learn from it is probably something the rest of us could do a bit more of.

I wish one of these pull requesters would comment on this post! I'd love to hear how they're going about reading your code and whether they're actually using Redis or just reading it for enjoyment.

I've heard similar things anecdotally from a developer that went to IIT in India. Had to read code first, with clarity, before they were able to sit down and code.

Any case you could share a link to one of these, if possible? A matter of curiosity.

First PR I saw on redis GH: https://github.com/antirez/redis/pull/4714

That same user also made https://github.com/antirez/redis/pull/4685

This may be? https://github.com/antirez/redis/pull/4622

This was apparently critical, but also kind of an edgecase: https://github.com/antirez/redis/pull/4568

& one more from someone else: https://github.com/antirez/redis/pull/4568

Probably soloestoy recently (but he also does a lot of Real world Redis) and Sun He in the past hold the records, but there are several...