News for hackers. Stuff that matters.
Re:Maintaining code quality when nobody cares by xstartup on Tuesday February 13, 2018 @09:34AM (#16367362)
What do you mean by throw away? The submitter can always make the requested changes. And if the pull requests are not even relevant then it's entirely a different issue.
Re:Maintaining code quality when nobody cares by tboyd47 on Tuesday February 13, 2018 @09:37AM (#16367387)
Meaning the submitter just spent one week writing code that will have to be written over again. If they had requested feedback informally before the PR, they would have written the code correctly the first time.
Re:Maintaining code quality when nobody cares by Bjartr on Tuesday February 13, 2018 @12:10PM (#16368732)
Having a PR workflow in place doesn't (or at least shouldn't) stop that person from seeking out that informal feedback earlier. To me it seems like what you're really looking for is pair programming, not pre-completion reviews.
Re:Maintaining code quality when nobody cares by Clubber on Tuesday February 13, 2018 @02:54PM (#16370160)
There is a dev design/plan time that could be utilized to solve that.